Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow digit separators after 0b, 0o, and 0x but before the digits #1020

Closed
5 tasks done
Happypig375 opened this issue Jun 3, 2021 · 4 comments
Closed
5 tasks done

Comments

@Happypig375
Copy link
Contributor

Allow digit separators after 0b, 0o, and 0x but before the digits

I propose we allow digit separators after 0b, 0o, and 0x but before the digits.

let x = 0b_1010_0000
let y = 0x_1234_abcd
let z = 0o_1234_4321

C# already implemented this in 7.2.

The existing way of approaching this problem in F# is to resist your stylistic preferences.

Pros and Cons

The advantages of making this adjustment to F# are

  1. Consistency with C#
  2. Freedom of expression
  3. Inclusivity!

The disadvantages of making this adjustment to F# are (none).

Extra information

Estimated cost (XS, S, M, L, XL, XXL): XS

Related suggestions: dotnet/roslyn#12680

Affidavit (please submit!)

Please tick this by placing a cross in the box:

  • This is not a question (e.g. like one you might ask on stackoverflow) and I have searched stackoverflow for discussions of this issue
  • I have searched both open and closed suggestions on this site and believe this is not a duplicate
  • This is not something which has obviously "already been decided" in previous versions of F#. If you're questioning a fundamental design decision that has obviously already been taken (e.g. "Make F# untyped") then please don't submit it.

Please tick all that apply:

  • This is not a breaking change to the F# language design
  • I or my company would be willing to help implement and/or test this

For Readers

If you would like to see this issue implemented, please click the 👍 emoji on this issue. These counts are used to generally order the suggestions by engagement.

@dsyme
Copy link
Collaborator

dsyme commented Jun 14, 2022

This feels too niche, I'm OK with F# not having this

@dsyme dsyme closed this as completed Jun 14, 2022
@Happypig375
Copy link
Contributor Author

@dsyme Instead of "niche", this is more like a very small improvement. Why not label this as a "good first issue" instead for new contributors? It's a net gain imo.

@dsyme
Copy link
Collaborator

dsyme commented Jun 15, 2022

I'll reopen of someone submits RFC and implementation :)

@dsyme
Copy link
Collaborator

dsyme commented Jun 16, 2022

This was actually a duplicate: #718

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants