Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fake.Dotnet.Cli.DotNetCompile is not user friendly #1792

Closed
MangelMaxime opened this issue Feb 21, 2018 · 2 comments
Closed

Fake.Dotnet.Cli.DotNetCompile is not user friendly #1792

MangelMaxime opened this issue Feb 21, 2018 · 2 comments
Labels

Comments

@MangelMaxime
Copy link
Contributor

Description

In the latest version of Fake.Dontet.Cli (5.0.0-beta-18), if I want to use the API I need to do:

DotNetCompile (fun c -> c()) proj

Here is the signature of DotNetCompile:

val DotNetCompile: 
   setParams: (unit -> DotNetBuildOptions) -> DotNetBuildOptions ->
   project  : string 
           -> unit

Expected behavior

I think the signature should be:

val DotNetCompile: 
   setParams: DotNetBuildOptions -> DotNetBuildOptions ->
   project  : string 
           -> unit

I think this is the how the API was previously.

@MangelMaxime MangelMaxime changed the title Fake.Dotnet.Cli is not user friendly Fake.Dotnet.Cli.DotNetCompile is not user friendly Feb 21, 2018
@matthid matthid added the bug label Feb 21, 2018
@matthid
Copy link
Member

matthid commented Feb 21, 2018

Yes good catch thanks

@matthid
Copy link
Member

matthid commented Mar 3, 2018

This has been released.

@matthid matthid closed this as completed Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants