Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing should be able to use time stamping and work on dev computers #533

Closed
Bomret opened this issue Sep 3, 2014 · 1 comment
Closed

Comments

@Bomret
Copy link

Bomret commented Sep 3, 2014

The current SignHelper does not provide options for time stamping signed assemblies and you have to check for the existence of the certificate file to use before you call it. I think the MageHelper handles the latter quite nicely by being able to provide a dev certificate that can safely be put into source control and allow to include the sign process into local dev builds. It would be nice to have a similar option for signing.
The only problem is: the current SignHelper already takes quite a lot of parameters and putting those new parameters there would make a call to it quite ugly. So it would be great to pass a parameters record like in the MageHelper that aggregates the available options. This would also make it easier to expand the call with new options later.

@Bomret Bomret changed the title Signing should be able to use time stamping and on dev computers Signing should be able to use time stamping and work on dev computers Sep 3, 2014
@dsyme
Copy link
Collaborator

dsyme commented Apr 14, 2016

Closing as this seems to have been covered by a PR

@dsyme dsyme closed this as completed Apr 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants