Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a .NET Standard compatible build on nuget #127

Closed
pkese opened this issue Jun 28, 2017 · 20 comments
Closed

Provide a .NET Standard compatible build on nuget #127

pkese opened this issue Jun 28, 2017 · 20 comments

Comments

@pkese
Copy link

pkese commented Jun 28, 2017

This package is only available as for dotnet 4.5 and can't be used in modern .Net Core / .Net Standard enironments (Linux...).

Is there a reason it can't be provided as Netstandard compatible.

@vasily-kirichenko
Copy link
Contributor

It's possible if SharpYaml package is Core compatible.

@pkese
Copy link
Author

pkese commented Jun 29, 2017

Yes,
SharpYaml is compatible with NetStandard 1.6
https://www.nuget.org/packages/SharpYaml/

@sergey-tihon
Copy link
Member

How is it possible? I thought that TP does not work yet on .NET Core - dotnet/fsharp#2406

@vasily-kirichenko Do you know at least one (erased) TP that is compiled to .net standard and work on .net core?

@vasily-kirichenko
Copy link
Contributor

Ah, I don't follow .NET Core news, I thought TPs are already supported.

@forki
Copy link
Member

forki commented Jul 3, 2017

@vasily-kirichenko no they are not.

@tylerhartwig
Copy link

I noticed there are alpha releases for .netstandard on nuget.

What is the state of those builds? How functional are they on netstandard?

@sergey-tihon
Copy link
Member

@tylerhartwig plz, try it and tell us ;)

It is in alpha because it is does not contain ResXProvider at the moment and there is no way auto-magically load web.config.

YamlConfigTypeProvider, IniFileProvider & AppSettingsTypeProvider should be in perfect shape (as good as before).

@baronfel
Copy link
Collaborator

I had issues with the yamlprovider in Rider and vscode with regards to intellisense, but they compiled perfectly.

@sergey-tihon
Copy link
Member

@baronfel what sorts of issues you had? Performance?
IIRC, current alpha does not contain caching for provided types. Can it be related?

@baronfel
Copy link
Collaborator

It was always just red squigglies for unknown members on the generated type. Just a design time issue, though! One of the many things I hadn't found time to run down.

@tylerhartwig
Copy link

Ah I'd love to try it out and let yall know, however I was hoping to try out the resx :D

Is that piece started? What does the work on that look like?

@sergey-tihon
Copy link
Member

@tylerhartwig yes, take a look here #139 (comment)

the original implementation is heavily rely on winforms that is not net-standard thing =(

@sergey-tihon
Copy link
Member

We also can ask @Liminiens opinion on how far we are ;)

@Liminiens
Copy link

@sergey-tihon i beleive it is be possible to target net core 3.0 for resx provider since it has win forms bits, but it needs some research

@sergey-tihon
Copy link
Member

@Liminiens maybe, but it anyway will be win-only. right?

@Liminiens
Copy link

yes :)

@jkone27
Copy link

jkone27 commented Aug 23, 2020

any news on .netstandard porting effort ? maybe YAML type provider should be in the main FSharp.Data library?

@sergey-tihon
Copy link
Member

@jkone27 have you tried 2.0.0-alpha2? It contains .net standard version of YAML type provider

@jkone27
Copy link

jkone27 commented Aug 24, 2020

Will give it a try, thanks a lot @sergey-tihon 👍

@jkone27
Copy link

jkone27 commented Aug 10, 2021

just a thought, but any thoughts of migrating it to FSharp.Data ? i think it could prove very useful and maybe it's a nicer fit there, or have a separate package/repo like FSharp.Data.Yaml ? Have a really nice day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants