Add null-checks for each function that takes an IAsyncEnumerable
or otherwise nullable type
#127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures we follow the same principles as F# Core in null-checking:
null
null
null
(arrays,IAsyncEnumerable<_>
,IEnumerable<_>
,ResizeArray<_>
and the like)While this is technically a breaking change (previously, users would've encountered a
NullReferenceException
which is now anArgumentNullException
), it is unlikely that this change will lead to much issues in practice, so we'll just add it to the next release with a warning in the release notes.This PR also removes the flexible types for
append/appendSeq/prependSeq
functions, which shouldn't be flexible. We only use flexible types with contravariance (i.e., HOF arguments).Done:
checkNonNull
to each function that takes ataskSeq<'T>
argument