Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download script links in docs broken #696

Closed
olivercoad opened this issue Jul 29, 2021 · 4 comments · Fixed by #697
Closed

Download script links in docs broken #696

olivercoad opened this issue Jul 29, 2021 · 4 comments · Fixed by #697

Comments

@olivercoad
Copy link

The download script links in the docs lead to gh pages 404.

For example on https://fsprojects.github.io/FSharp.Formatting/content.html it links to https://fsprojects.github.io/FSharp.Formatting/content.fsx which is a 404 page.

The fsx scripts don't exist on the gh-pages branch. Either the fsx files should be copied into the gh-pages build or it could link directly to the source file on github, ideally with the git commit sha that that doc was built from, such as https://github.com/fsprojects/FSharp.Formatting/blob/49ee266b0d5c2cb3baa468add69b4439a39dea6f/docs/content.fsx

@dsyme
Copy link
Contributor

dsyme commented Jul 29, 2021

Looks like _template.fsx was missing, added now, thanks!

364e6c1

@dsyme
Copy link
Contributor

dsyme commented Jul 29, 2021

Cool this is fixed, thanks for the report!

@dsyme dsyme closed this as completed Jul 29, 2021
@olivercoad
Copy link
Author

Is the downloaded file meant to be empty? https://fsprojects.github.io/FSharp.Formatting/content.fsx now seems be just a single line feed character.

@dsyme dsyme reopened this Jul 29, 2021
@dsyme dsyme mentioned this issue Jul 29, 2021
@dsyme
Copy link
Contributor

dsyme commented Jul 29, 2021

Really fixed now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants