Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed location of F# SDK in Visual Studio 15.8 leads to compilation errors #249

Closed
bartsokol opened this issue Aug 19, 2018 · 1 comment
Labels

Comments

@bartsokol
Copy link

Description

In Visual Studio version 15.8 F# SDK was moved inside the installation directory of the VS, so the paths provided in the fsc.props file don't point to SDK any more. Thus solving issue with type providers and .NET Core SDK decribed here requires adding new paths.

One problem is that now the path is dependent on the variant of the VS installed (Community vs Professional vs...), so there needs to be a path added for each variant in use.

Repro steps

  • Install Visual Studio 2017 version 15.8 on your machine, without having separate F# SDK installed
  • Try to compile the code using type providers (in my case it was Swagger Provider) using dotnet CLI

Expected behavior

Code compiles.

Actual behavior

Compilation ends with error.

Known workarounds

Put new path to SDK in local props file (e.g. Directory.build.props) for all variants of Visual Studio that are in use in your organization. For Community variant it would be:

  <PropertyGroup Condition="'$(IsWindows)' == 'true' AND Exists('C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\CommonExtensions\Microsoft\FSharp\fsc.exe')">
    <FscToolPath>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\CommonExtensions\Microsoft\FSharp</FscToolPath>
    <FscToolExe>fsc.exe</FscToolExe>
  </PropertyGroup>

Related information

  • Windows 10
  • Visual Studio 15.8, .NET Core SDK 2.1.400
@dsyme
Copy link
Contributor

dsyme commented Sep 6, 2018

Fixed in fsc.props

@dsyme dsyme closed this as completed Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants