Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multi-target builds using Mono #118

Closed
sergey-tihon opened this issue Mar 3, 2018 · 3 comments · Fixed by #119
Closed

Support multi-target builds using Mono #118

sergey-tihon opened this issue Mar 3, 2018 · 3 comments · Fixed by #119

Comments

@sergey-tihon
Copy link
Member

Tips here - dotnet/sdk#335 (comment)
@atlemann
Copy link
Contributor

atlemann commented Mar 4, 2018

Hi! I'm working on this. Have never done a PR before, so I'm not sure how to proceed. I have forked the repo and created a branch which I have pushed to my fork. I made the build work using the proposed technique, but there is still stuff I want to fix. Should I open a [WIP] PR to here now?

@atlemann
Copy link
Contributor

atlemann commented Mar 4, 2018

While I was trying to get the build fixed, I upgraded FSharp.Core to the latest to get rid of the netstandard1.6 dependency, which I guess was requested here: #116

@sergey-tihon
Copy link
Member Author

Awesome! Yes, please open PR even with WIP version.

@atlemann atlemann mentioned this issue Mar 4, 2018
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding support for multi-target builds using Mono atlemann/FsUnit
2 participants
@sergey-tihon @atlemann