Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FsUnit vNext #258

Closed
4 tasks done
CaptnCodr opened this issue Dec 6, 2023 · 8 comments
Closed
4 tasks done

FsUnit vNext #258

CaptnCodr opened this issue Dec 6, 2023 · 8 comments
Assignees

Comments

@CaptnCodr
Copy link
Member

CaptnCodr commented Dec 6, 2023

Developments of FsUnit's dependencies are going on and FsUnit needs to adapt sometimes. (nunit/nunit#4568)

As I mentioned here: #256 (comment)

I will make a plan for the NUnit 4.0.0 migration. NUnit 3.X will be supported for the time being.

In the meantime of discussing in the NUnit repository I made a little plan to migrate to NUnit v4 + maintaining NUnit v3.X side-by-side. NUnit v3.X will be maintained for bugfixes etc.

I researched some thingies, evaluated those and that's my plan:

  • Project FsUnit.NUnit will be migrated to NUnit v4, stays FsUnit on nuget, exported for net462 & net6.0
    - New Project FsUnit.NUnit3 gets the old code, gets FsUnit.NUnit3 on nuget, exported for netstandard2.0 & net6.0 (as before)
  • Both FsUnit.NUnit and FsUnit.NUnit3 get the same nuget version every update
  • Can be built side-by-side in existing solution

Further updates:

  • Upgrading MsTest to 3.x
  • Clean ups

Recommended FsUnit vNext is 6.0.0, release eta mid January 2024

Checklist:

@sergey-tihon Do you have some suggestions or more points for the checklist?

@CaptnCodr CaptnCodr self-assigned this Dec 6, 2023
@sergey-tihon
Copy link
Member

Project FsUnit.NUnit will be migrated to NUnit v4, stays FsUnit on nuget, exported for net462 & net6.0

Agree, but I think that there is no need to support net462 anymore. in my opinion net6 is enough

New Project FsUnit.NUnit3 gets the old code, gets FsUnit.NUnit3 on nuget, exported for netstandard2.0 & net6.0 (as before)

It is up to you, but I do not see the need for such support. If I am on the old .NET I am should be fine to not update dependencies, NUnit version will be fixed anyway, FsUnit does not have so many bugs and fixes.

@CaptnCodr
Copy link
Member Author

Thank you for your evaluation, I respect that.

@nojaf
Copy link

nojaf commented Dec 11, 2023

Hello, we would like to update Fantomas to NUnit 4 and we would require a new version of FsUnit with the bump. Please consider releasing an alpha package when you have something. Thanks!

@CaptnCodr
Copy link
Member Author

Hi Florian, I will notify you, when there's an alpha version!

@nojaf
Copy link

nojaf commented Dec 11, 2023

Thank you!

@CaptnCodr
Copy link
Member Author

CaptnCodr commented Dec 12, 2023

@nojaf Hi Florian, FsUnit 6.0.0-alpha1 is now available.
Please give me feedback if everything works as expected, if not -> raise an issue. ;)

@nojaf
Copy link

nojaf commented Dec 13, 2023

Works for us! Thanks Constantin!

@CaptnCodr
Copy link
Member Author

FsUnit v6.0 is now available!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants