Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The task "Rebuild" was replaced by "Build" task in target "Build" #260

Closed
wants to merge 1 commit into from

Conversation

Chicker
Copy link

@Chicker Chicker commented Jun 15, 2016

Also, the target "Rebuild" with the "Rebuild" task was added in "build.template" file.

This commit fixes #258

…"build.template" file.

Also, the target "Rebuild" with the "Rebuild" task was added in "build.template" file.
@forki
Copy link
Member

forki commented Aug 10, 2016

@pblasucci what do we do with this?

@pblasucci
Copy link
Collaborator

@forki Personally, it seems a bit "off" to me. I understand wanting to speed up incremental builds. But I strongly believe the Release target should work off of a fully clean rebuild. Also, I've never found the perf difference between "Build" and "Rebuild" to be worth the headache of having separate commands. What are your thoughts?

@forki
Copy link
Member

forki commented Aug 10, 2016

Yeah I think we should not merge it. I mean it's a good idea for some use
cases but I think we should play it safe for the scheduling process.

On Aug 10, 2016 2:39 PM, "Paulmichael Blasucci" notifications@github.com
wrote:

@forki https://github.com/forki Personally, it seems a bit "off" to me.
I understand wanting to speed up incremental builds. But I strongly believe
the Release target should work off of a fully clean rebuild. Also, I've
never found the perf difference between "Build" and "Rebuild" to be worth
the headache of having separate commands. What are your thoughts?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#260 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNIi892Qd8FGaHhe7ArwHWNzI2Pqsks5qecaVgaJpZM4I2NX6
.

@pblasucci
Copy link
Collaborator

Agreed. Also, when you consider the way certain things (in VS/MSBuild) get cached, this doesn't feel like a "safe default".

Closing as "too specialized".

@pblasucci pblasucci closed this Aug 10, 2016
@forki
Copy link
Member

forki commented Aug 10, 2016

@Chicker we still really appreciate that you took the time and effort. It's not a bad idea. I hope you can understand the reasoning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why used Rebuild task instead Build in build.template file?
3 participants