Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSFS / FSUIPC 7 compatibility #8

Closed
Flusinerd opened this issue Jan 28, 2021 · 7 comments
Closed

MSFS / FSUIPC 7 compatibility #8

Flusinerd opened this issue Jan 28, 2021 · 7 comments

Comments

@Flusinerd
Copy link
Contributor

Any chance this gets updated to work with MSFS and FSUIPC v7
Im building an cross sim acars, so I would greatly benefit from this.
If I can get some hints, I might be able to do it myself and create a PR.

Sincerely, Jan

@blackholegalaxy
Copy link
Contributor

blackholegalaxy commented Jan 29, 2021

Hi @Flusinerd I'm currently reviewing the documentation for FSUIPC new gen. A lot of offsets have moved. I am still waiting for a more stable offset list from FSUIPC and was not able to find an up to date list of offset address and potential new entries. If we get some list, continuing this would be a breeze.

@Flusinerd
Copy link
Contributor Author

Okay ty for the quick response. I managed to track down the issue to it not connecting due to the unknown simulator. I managed to "fix" it by calling the globalInstance.open() method without any parameters. This way it connects to any simulator also including fusipc v7. This works for me, since the offsets I use don't seem to have changed.

This is my hacky fix:

https://github.com/Flusinerd/api/commit/0de1fdcc4d4b8532adf7a580f00b0b13512cd909

@blackholegalaxy
Copy link
Contributor

Do you want to open a PR for this? It could do the trick while testing new offsets.

@Flusinerd
Copy link
Contributor Author

Sure :)

@Flusinerd
Copy link
Contributor Author

Done
#9

@Flusinerd
Copy link
Contributor Author

@blackholegalaxy
koesie10/fsuipc-node#8
I created a pull request for the fsuipc node module. This adds MSFS to the Simulators enum.
Once this gets merged, we can go back to the default behavior.

@blackholegalaxy
Copy link
Contributor

blackholegalaxy commented Feb 1, 2021

If original fsuipc node module owner doesn't merge, we could fork the core module on our scope and create a @fsuipc/core package. You would just have to point your pull request to https://github.com/fsuipc-node/core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants