Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scalafix integration #153

Merged
merged 26 commits into from
Jun 15, 2019
Merged

scalafix integration #153

merged 26 commits into from
Jun 15, 2019

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Nov 15, 2018

Towards #149. There is not much here yet, but I think it makes sense to open this PR anyway as place for further discussion.

/cc @amarrella @Daenyth

@codecov
Copy link

codecov bot commented Nov 15, 2018

Codecov Report

Merging #153 into master will increase coverage by 1.48%.
The diff coverage is 80.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
+ Coverage   58.04%   59.53%   +1.48%     
==========================================
  Files          65       67       +2     
  Lines         820      865      +45     
  Branches       39       37       -2     
==========================================
+ Hits          476      515      +39     
- Misses        344      350       +6
Impacted Files Coverage Δ
...la/org/scalasteward/core/application/Context.scala 0% <ø> (ø) ⬆️
...main/scala/org/scalasteward/core/sbt/command.scala 100% <100%> (ø) ⬆️
...main/scala/org/scalasteward/core/util/string.scala 81.48% <100%> (+0.71%) ⬆️
...main/scala/org/scalasteward/core/sbt/package.scala 60% <100%> (+4.44%) ⬆️
.../main/scala/org/scalasteward/core/sbt/SbtAlg.scala 48.78% <20%> (-4%) ⬇️
...ain/scala/org/scalasteward/core/edit/EditAlg.scala 91.66% <75%> (-8.34%) ⬇️
...in/scala/org/scalasteward/core/model/Version.scala 87.5% <87.5%> (ø)
...scala/org/scalasteward/core/scalafix/package.scala 90% <90%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5716ec4...df9710c. Read the comment docs.

Copy link
Contributor

@Daenyth Daenyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As good as place as any to start

@fthomas
Copy link
Member Author

fthomas commented Nov 27, 2018

scala-steward just created its first PR using a scalafix migration!
fthomas/scala-pet-store#13

Unfortunately the scalafix changes are not nicely formatted so we probably need to run scalafmt before creating the PR.

@fthomas fthomas changed the title WIP: scalafix integration scalafix integration Jun 15, 2019
@fthomas fthomas added the enhancement New feature or request label Jun 15, 2019
@fthomas fthomas added this to the 0.3.0 milestone Jun 15, 2019
@fthomas
Copy link
Member Author

fthomas commented Jun 15, 2019

The latest PR created with the changes on this branch is https://github.com/fthomas/scalafix-test/pull/5/files

@fthomas fthomas merged commit 9b9e894 into master Jun 15, 2019
@fthomas fthomas deleted the topic/scalafix branch June 15, 2019 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants