Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore SNAPSHOT updates if current version is not already a SNAPSHOT #485

Merged
merged 2 commits into from
May 10, 2019
Merged

Ignore SNAPSHOT updates if current version is not already a SNAPSHOT #485

merged 2 commits into from
May 10, 2019

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented May 10, 2019

closes #483

@codecov
Copy link

codecov bot commented May 10, 2019 •
edited
Loading

Codecov Report

Merging #485 into master will increase coverage by 0.29%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
+ Coverage   55.18%   55.48%   +0.29%     
==========================================
  Files          63       63              
  Lines         743      748       +5     
  Branches       33       33              
==========================================
+ Hits          410      415       +5     
  Misses        333      333
Impacted Files Coverage Δ
...scala/org/scalasteward/core/update/FilterAlg.scala 61.76% <100%> (+6.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10a8af9...ff6104d. Read the comment docs.

@fthomas fthomas merged commit 5ea251a into master May 10, 2019
@fthomas fthomas added the bug Something isn't working label May 10, 2019
@fthomas fthomas added this to the 0.3.0 milestone May 10, 2019
@fthomas fthomas mentioned this pull request May 10, 2019
Closed
@fthomas fthomas deleted the topic/ignore-non-snap-to-snap branch May 10, 2019 20:08
fthomas added a commit that referenced this pull request Sep 30, 2019
@fthomas
Prevent updates to a pre-release of another series
f931cda 
This contains code from #851 for preventing updates to a pre-release of
another version series. Version.selectNext is now responsible for
selecting the next version from a list of possible newer versions. This
functions implements the scheme described in
https://github.com/fthomas/scala-steward/blob/master/docs/faq.md#how-does-scala-steward-decide-what-version-it-is-updating-to
and also filters out all bumps between pre-releases of different version
series. This code incidentally also makes the code to deal with updates
from non-snapshot to snapshot versions (#485) superfluous.

Closes #956.
@fthomas fthomas mentioned this pull request Sep 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

suggestion: don't suggest SNAP/SNAPSHOT versions unless I'm already on one
1 participant
@fthomas