Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cross-version suffix from artifactIds #493

Merged
merged 4 commits into from
May 15, 2019
Merged

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented May 15, 2019

This makes it easier to compare them with updates of created
PRs which are already persisted without cross-version suffix.

This makes it easier to compare them with updates of created
PRs which are already persisted without cross-version suffix.
@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #493 into master will decrease coverage by 0.23%.
The diff coverage is 12.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
- Coverage   56.75%   56.51%   -0.24%     
==========================================
  Files          64       64              
  Lines         770      775       +5     
  Branches       32       31       -1     
==========================================
+ Hits          437      438       +1     
- Misses        333      337       +4
Impacted Files Coverage Δ
...a/org/scalasteward/core/update/UpdateService.scala 0% <0%> (ø) ⬆️
.../main/scala/org/scalasteward/core/sbt/SbtAlg.scala 54.05% <0%> (-6.56%) ⬇️
...ain/scala/org/scalasteward/core/model/Update.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d57fab...a20ea5f. Read the comment docs.

@fthomas fthomas merged commit 2ea66e7 into master May 15, 2019
@fthomas fthomas deleted the topic/no-cross-suffix branch May 16, 2019 18:00
@fthomas fthomas added this to the 0.3.0 milestone May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant