Refactor to move github/data to vcs/data #497
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly changes to prevent the PR with the actual logic to be obfuscated. I move the data structures from github/data to vcs/data. I also rename the
GitHubRepoAlg
toVCSRepoAlg
.With this PR, we are assuming the data structures (used to talk to GitHub) will work for any VCS be it BitBucket and GitLab. In reality, it's a bit of a stretch. I've made it work with a bunch of shortcut (as a prototype it ran on one of our internal repository and it opened a bunch of PR 👍 ). But we'll need to discuss what needs to change in those structures in order to accommodate other VCS when I open the PR with the actual logic.
The actual changes would look like:
Url
classVCSApiAlg