Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add heuristic that uses words from the groupId #545

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Add heuristic that uses words from the groupId #545

merged 1 commit into from
Jun 5, 2019

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Jun 5, 2019

No description provided.

@codecov
Copy link

codecov bot commented Jun 5, 2019 •
edited
Loading

Codecov Report

Merging #545 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #545     +/-   ##
=========================================
+ Coverage   55.74%   55.85%   +0.1%     
=========================================
  Files          64       64             
  Lines         809      811      +2     
  Branches       34       37      +3     
=========================================
+ Hits          451      453      +2     
  Misses        358      358
Impacted Files Coverage Δ
...main/scala/org/scalasteward/core/util/string.scala 80% <100%> (ø) ⬆️
...ain/scala/org/scalasteward/core/model/Update.scala 100% <100%> (ø) ⬆️
.../scala/org/scalasteward/core/nurture/EditAlg.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e521900...0ba5c4a. Read the comment docs.

@fthomas fthomas merged commit 2802788 into master Jun 5, 2019
@fthomas
Copy link
Member Author

fthomas commented Jun 6, 2019

This heuristic needs to be changed to prevent PRs like these:

fthomas added a commit that referenced this pull request Jun 6, 2019
@fthomas
Refine replaceAllInGroupId
c08edf4 
... to prevent PRs listed in #545 (comment)

This change drops the TLD from the groupId and only uses words that are
longer than three characters.
@fthomas fthomas mentioned this pull request Jun 6, 2019
Merged
@fthomas fthomas deleted the topic/use-words-from-groupId branch June 7, 2019 20:06
@fthomas fthomas added the enhancement New feature or request label Jun 7, 2019
@fthomas fthomas added this to the 0.3.0 milestone Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
1 participant
@fthomas