Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine replaceAllInGroupId #547

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Jun 6, 2019

... to prevent PRs listed in #545 (comment)

This change drops the TLD from the groupId and only uses words that are
longer than three characters.

... to prevent PRs listed in #545 (comment)

This change drops the TLD from the groupId and only uses words that are
longer than three characters.
@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #547 into master will increase coverage by 0.14%.
The diff coverage is 88.88%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #547      +/-   ##
========================================
+ Coverage   55.85%    56%   +0.14%     
========================================
  Files          64     64              
  Lines         811    816       +5     
  Branches       37     45       +8     
========================================
+ Hits          453    457       +4     
- Misses        358    359       +1
Impacted Files Coverage Δ
...ain/scala/org/scalasteward/core/model/Update.scala 98.21% <88.88%> (-1.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9145e1f...c08edf4. Read the comment docs.

@fthomas fthomas merged commit 2d92354 into master Jun 6, 2019
@fthomas fthomas deleted the topic/refine-replaceAllInGroupId branch June 7, 2019 20:08
@fthomas fthomas added the bug Something isn't working label Jun 7, 2019
@fthomas fthomas added this to the 0.3.0 milestone Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant