Include repo in head param when searching for PRs #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug when searching for already existing PRs in a repo where scala-steward's repo has a different name because the parent was moved or renamed after scala-steward forked it. When the repo names differ, the name must be included into the head parameter like this: ``` head=scala-steward/scalaz-zio:update/scalaz-core-7.3.0-M30 ``` Prior to this change, the parameter looked like this: ``` head=scala-steward:update/scalaz-core-7.3.0-M30 ``` But this only works when the names are equal. One consequence of this bug are duplicated PRs like these: * zio/zio#991 * zio/zio#983
Codecov Report
@@ Coverage Diff @@
## master #552 +/- ##
==========================================
- Coverage 55.95% 55.89% -0.06%
==========================================
Files 64 64
Lines 815 814 -1
Branches 46 45 -1
==========================================
- Hits 456 455 -1
Misses 359 359
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug when searching for already existing PRs in a repo
where scala-steward's repo has a different name because the parent
was moved or renamed after scala-steward forked it.
When the repo names differ, the name must be included into the head
parameter like this:
Prior to this change, the parameter looked like this:
But this only works when the names are equal. Including the repo name
is also okay if there is no difference.
One consequence of this bug are duplicated PRs like these: