Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BigInt instead of Long for the numeric parts of Version #579

Merged
merged 1 commit into from
Jun 16, 2019

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Jun 16, 2019

So we don't have to care about really really long version numbers.

So we don't have to care about really really long version numbers.
@fthomas fthomas added this to the 0.3.0 milestone Jun 16, 2019
@codecov
Copy link

codecov bot commented Jun 16, 2019

Codecov Report

Merging #579 into master will not change coverage.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #579   +/-   ##
=======================================
  Coverage   59.02%   59.02%           
=======================================
  Files          67       67           
  Lines         859      859           
  Branches       41       38    -3     
=======================================
  Hits          507      507           
  Misses        352      352
Impacted Files Coverage Δ
...in/scala/org/scalasteward/core/model/Version.scala 93.33% <85.71%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 105403b...8caf486. Read the comment docs.

@fthomas fthomas merged commit 57eff51 into master Jun 16, 2019
@fthomas fthomas deleted the topic/use-bigint branch June 16, 2019 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant