Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a fantastic day writing Scala! #583

Merged
merged 1 commit into from
Jun 17, 2019

Conversation

kubukoz
Copy link
Contributor

@kubukoz kubukoz commented Jun 17, 2019

No description provided.

@kubukoz
Copy link
Contributor Author

kubukoz commented Jun 17, 2019

[info] VersionTest:
[info] - Order[Version].order.antisymmetry *** FAILED ***
[info]   GeneratorDrivenPropertyCheckFailedException was thrown during property evaluation.
[info]    (Discipline.scala:14)
[info]     Falsified after 2 successful property evaluations.
[info]     Location: (Discipline.scala:14)
[info]     Occurred when passed generated values (
[info]       arg0 = Version(r.s.0.),
[info]       arg1 = Version(-),
[info]       arg2 = org.scalacheck.GenArities$$Lambda$1320/817855147@5329fbbe
[info]     )
[info]     Label of failing property:
[info]       Expected: true
[info]   Received: false

That doesn't seem related...

@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #583 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #583   +/-   ##
=======================================
  Coverage   59.09%   59.09%           
=======================================
  Files          67       67           
  Lines         858      858           
  Branches       40       40           
=======================================
  Hits          507      507           
  Misses        351      351
Impacted Files Coverage Δ
...calasteward/core/vcs/data/NewPullRequestData.scala 85.71% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebd7775...dee2c60. Read the comment docs.

@fthomas
Copy link
Member

fthomas commented Jun 17, 2019

No, that is not related. But yay for property-based testing!

Thanks for the fantastic PR, @kubukoz!

@fthomas fthomas merged commit 3774160 into scala-steward-org:master Jun 17, 2019
@kubukoz kubukoz deleted the fantastic-day branch June 17, 2019 19:39
@fthomas fthomas added the enhancement New feature or request label Jun 22, 2019
@fthomas fthomas added this to the 0.3.0 milestone Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants