Ignore dependencies introduced by plugins #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ignores dependencies of a repo which are not defined in the build files but are introduced by plugins. This allows scala-steward to prune more repositories it doesn't need to look at. Without this scala-steward tried to update dependencies which were never defined in the build files and therefore couldn't be updated.
Codecov Report
@@ Coverage Diff @@
## master #584 +/- ##
==========================================
- Coverage 59.09% 59.04% -0.05%
==========================================
Files 67 67
Lines 858 857 -1
Branches 40 39 -1
==========================================
- Hits 507 506 -1
Misses 351 351
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #584 +/- ##
==========================================
- Coverage 59.09% 59.04% -0.05%
==========================================
Files 67 67
Lines 858 857 -1
Branches 40 39 -1
==========================================
- Hits 507 506 -1
Misses 351 351
Continue to review full report at Codecov.
|
fthomas
added a commit
that referenced
this pull request
Oct 19, 2020
This reverts #584 which shouldn't be needed any more since #1188. The goal of #584 was to ignore dependencies that are added by plugins because those dependencies cannot be updated. Unfortunately this solution is brittle because it also ignores plugins that are added via `addSbtPlugin` in `settings`, see http4s/sbt-http4s-org#26 (comment). (They also have a source position like ` LinePosition(Defaults.scala,...)`.) A similar optimization was later added in #1188 which ignores all dependencies whose versions number cannot be found in files of the repo. This optimization also covers dependencies that are added by plugins. Let's see if this is good enough to also cover #584.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ignores dependencies of a repo which are not defined in the build
files but are introduced by plugins. This allows scala-steward to prune
more repositories it doesn't need to look at. Without this scala-steward
tried to update dependencies which were never defined in the build files
and therefore couldn't be updated.