Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny code tweaks #587

Merged
merged 2 commits into from
Jun 18, 2019
Merged

Conversation

jhnsmth
Copy link
Contributor

@jhnsmth jhnsmth commented Jun 18, 2019

Just notice this while browsing the sources. Please, feel absolutely free to reject this PR.

@codecov
Copy link

codecov bot commented Jun 18, 2019

Codecov Report

Merging #587 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #587   +/-   ##
=======================================
  Coverage   59.04%   59.04%           
=======================================
  Files          67       67           
  Lines         857      857           
  Branches       39       39           
=======================================
  Hits          506      506           
  Misses        351      351
Impacted Files Coverage Δ
.../scala/org/scalasteward/core/application/Cli.scala 100% <ø> (ø) ⬆️
...la/org/scalasteward/core/application/Context.scala 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bce2178...f5392b3. Read the comment docs.

implicit0(config: Config) <- Resource.liftF(Config.create[F](cliArgs_))
implicit0(client: Client[F]) <- BlazeClientBuilder[F](ExecutionContext.global).resource
implicit0(logger: Logger[F]) <- Resource.liftF(Slf4jLogger.create[F])
implicit0(user: AuthenticatedUser) <- Resource.liftF(config.gitHubUser[F])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change!

@fthomas fthomas merged commit 635ce02 into scala-steward-org:master Jun 18, 2019
@fthomas
Copy link
Member

fthomas commented Jun 18, 2019

Thanks @jhnsmth!

@jhnsmth jhnsmth deleted the topic/tiny-code-tweaks branch June 18, 2019 13:47
@fthomas fthomas added this to the 0.3.0 milestone Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants