Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elevate pre release semver #648

Merged

Conversation

ChristopherDavenport
Copy link
Contributor

Found an error in SemVer when going from 0.20.0-M3 to 0.20.3 was labelled semver-patch which does not seem consistent with https://semver.org/

Hopefully this doesn't affect the system in another way I don't expect

@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #648 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #648   +/-   ##
=======================================
  Coverage   60.15%   60.15%           
=======================================
  Files          66       66           
  Lines         876      876           
  Branches       17       17           
=======================================
  Hits          527      527           
  Misses        349      349
Impacted Files Coverage Δ
...ain/scala/org/scalasteward/core/model/SemVer.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9aa64b...adeb461. Read the comment docs.

Copy link
Member

@fthomas fthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ChristopherDavenport!

SemVer is currently only used for labelling, so this change is safe.

@fthomas fthomas added the bug Something isn't working label Jul 2, 2019
@fthomas fthomas added this to the 0.3.0 milestone Jul 2, 2019
@fthomas fthomas merged commit e4b3a75 into scala-steward-org:master Jul 2, 2019
@ChristopherDavenport ChristopherDavenport deleted the elevatePreReleaseSemver branch July 2, 2019 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants