-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comparison traits for wide types not accessible on API #132
Comments
If you don't see any concerns with this, I'd be more than happy to open a PR :) |
Yeah these should probably be re-exported. Maybe in a |
I had some time to have a look at this, and I'm having a bit of a hard time settling on a suitable module for these traits. Sorry in advance for the long-ish post, I'm fairly new to Rust and not super familiar yet with project structure common practices. :) I'm wondering, what would you think would be the best course of action here? |
Currently the comparison traits
CmpEq
,CmpGt
,CmpGe
,CmpNe
,CmpLt
,CmpLe
are not exported from the crate, which makes dealing with wide types inconvenient.It's possible to add
wide
as a separate dependency and import the comparison traits, which is far from ideal. Considering the wide float types are re-exported from ultraviolet and are rather crucial to effectively using uv's own wide types, I think these traits should also be re-exported on ultraviolet's API.Use of
cmp_gt
is also mentioned in the Ray-Sphere Intersection example on README.The text was updated successfully, but these errors were encountered: