-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Firebase Authentication ID Tokens #9
Open
Charles-Johnson
wants to merge
26
commits into
fuchsnj:master
Choose a base branch
from
Charles-Johnson:firebase-auth
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still need to check auth_time claim is before exp claim
Abstract GoogleKeyProvider to a trait that is implemented by GoogleSignKeyProvider and FirebaseAuthenticationKeyProvider. Abstract RequiredClaims and IdPayload to associated types of the Validator trait which is implemented by GoogleSigninValidator and FirebaseValidator. Still need to expose the new API, include a check for auth_time claim for FirebaseValidator, expand FirebaseIdPayload, test FirebaseClient using custom key provider and refactor.
std::sync::Mutex::lock blocks the thread so will cause deadlocks when run inside a tokio runtime. using tokio::sync::Mutex in a TokioClient fixes this deadlock as tested in test_deadlock_prevention. It seems as though each async runtime will have to be explicitly supported
Client::firebase_builder, Client::google_signin_builder, Client::new_firebase and Client::new_google_signin to construct any kind of client from Client
No need to have to explicitly import Claims trait if method is inherent
A lot of information was being lost when converting 3rd party library errors to this crate's Error type. Error::InvalidToken is particularly unhelpful for users of this library because it represented so many different underlying errors. Error has been restructured so that it contains all underlying error information. Replaced unsafe_ignore_expiration method with unsafe_mock_timestamp method that it can be used to test firebase token validation in a deterministic way. Instead of claims_are_valid method for Validator, use validate_claims method that returns the error corresponding to a failing validation condition of the claim. This allows specific error information to propogate to the library user.
Didn't include firebase claim, couldn't find documentation explaining all possible values it could be
Also add FirebaseIdPayload and FirebaseRequiredClaims to the public API
Instead of using get_payload, using move_payload prevents unnecessary cloning of the payload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8
Usage
with
blocking
featurewith
async
featureProgress
GoogleKeyProvider
to support both Google Signin and Firebase AuthenticationRequiredClaims
for Google Signin and Firebase AuthenticationIdPayload
for Google Signin and Firebase Authenticationauth_time
claim is in the past for firebase tokensFirebaseIdPayload
to cover most of firebase token payload schemaFirebaseClient
using custom key provider