Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] extension input validation #81

Closed
goodwanghan opened this issue Oct 24, 2020 · 1 comment · Fixed by #90
Closed

[FEATURE] extension input validation #81

goodwanghan opened this issue Oct 24, 2020 · 1 comment · Fixed by #90
Labels
Milestone

Comments

@goodwanghan
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
NA

Describe the solution you'd like
We need certain level of extension validation, some can be done at workflow compile time and some can be done in runtime, for example

# input has: a,b:str,c,d:int
# prepartition has: a,b
# presort has: c,d desc
# schema: *
def dummy_transformer(df:pd.DataFrame) -> pd.DataFrame:
      return df

Decorator and interfaces should also support this type validation. We should start implementing from the interface level.

input has: can only be verified in runtime, because the schemas can be dynamic. But other validations can be done during the dag construction, it can save significant time to find problems, also it is very expressive.

Describe alternatives you've considered
NA

Additional context
NA

@goodwanghan goodwanghan added this to the 0.4.5 milestone Oct 24, 2020
@goodwanghan
Copy link
Collaborator Author

we can use has(contains) and is(equals)

@goodwanghan goodwanghan linked a pull request Oct 30, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant