Fix incorrect @onKey method header check

[github-actions]

fulibFx/framework/src/main/java/org/fulib/fx/controller/ControllerManager.java

Line 669 in 6fde075

// TODO: Utility method

        defaultResourceBundle = resourceBundle;
    }

    /**
     * Creates an event handler for the given method and instance that will be called when the specified key event occurs.
     *
     * @param method     The method to call
     * @param instance   The instance to call the method on
     * @param annotation The annotation with the key event information
     * @return An event handler for the given method and instance
     */
    private EventHandler<KeyEvent> createKeyEventHandler(Method method, Object instance, onKey annotation) {
        boolean hasEventParameter = method.getParameterCount() == 1 && method.getParameterTypes()[0].isAssignableFrom(KeyEvent.class);
        method.setAccessible(true);

        return event -> {
            // TODO: Utility method
            if ((annotation.code() == KeyCode.UNDEFINED || event.getCode() == annotation.code()) &&
                    (annotation.character().isEmpty() || event.getCharacter().equals(annotation.character())) &&
                    (annotation.text().isEmpty() || event.getText().equals(annotation.text())) &&
                    (event.isShiftDown() || !annotation.shift()) &&
                    (event.isControlDown() || !annotation.control()) &&
                    (event.isAltDown() || !annotation.alt()) &&
                    (event.isMetaDown() || !annotation.meta())
            ) {
                try {
                    if (hasEventParameter) {
                        method.invoke(instance, event);
                    } else {
                        method.invoke(instance);
                    }
                } catch (IllegalAccessException | InvocationTargetException e) {
                    throw new RuntimeException("Couldn't call method '" + method.getName() + "' in class '" + instance.getClass().getName() + "' on key event.", e);
                }
            }
        };
    }

    /**
     * Clears all key handlers registered for the given instance.
     *
     * @param instance The instance to clear the key handlers for
     */
    private void cleanUpListeners(Object instance) {
        Collection<Pair<onKey.Target, EventHandler<KeyEvent>>> handlers = keyEventHandlers.get(instance);
        if (handlers != null) {
            for (Pair<onKey.Target, EventHandler<KeyEvent>> handler : handlers) {
                switch (handler.getKey()) {
                    case SCENE -> app.get().stage().getScene().removeEventFilter(KeyEvent.ANY, handler.getValue());
                    case STAGE -> app.get().stage().removeEventFilter(KeyEvent.ANY, handler.getValue());
                }
            }
            keyEventHandlers.remove(instance);
        }
    }


    /**
     * Returns the title of the given controller instance if it has one.
     * If the title is a key, the title will be looked up in the resource bundle of the controller.

[Clashsoft]

I just noticed there is a bug:

        boolean hasEventParameter = method.getParameterCount() == 1 && method.getParameterTypes()[0].isAssignableFrom(KeyEvent.class);

If the second condition is false, e.g. because the method is declared as

@onKey(...)
void wrongKey(String key) {
}

Then it will call method.invoke(instance); and error with Couldn't call method ....

So either the second condition can be removed, or there needs to be separate error. Possibly even an annotation processor check which should be trivial.

[LeStegii]

Fixed in #64