Refactoring

[Clashsoft]

• There are many uses of control statements without braces, which is a warning and discouraged. Please fix.
• Rename OnXY annotations #84
• The ControllerUtil.isController method actually checks if the given object is a Controller OR a Component. It should be named more aptly isControllerOrComponent. In addition, an actual isController method should be added. This example could benefit greatly:
  

  fulibFx/framework/src/main/java/org/fulib/fx/controller/ControllerManager.java

  Lines 196 to 199 in 4264510

  	// Check if the instance is a controller/component
  	boolean component = instance.getClass().isAnnotationPresent(Component.class) && ControllerUtil.isComponent(instance);
  	if (!component && !instance.getClass().isAnnotationPresent(Controller.class))

• This is a stream that only ever processes a single element:

  fulibFx/framework/src/main/java/org/fulib/fx/controller/ControllerManager.java

  Lines 414 to 431 in 4264510

  	return fields
  	.stream()
  	.filter(field -> {
  	if (field.getType().isAssignableFrom(ResourceBundle.class))
  	return true;
  	throw new RuntimeException(error(2004).formatted(field.getName(), instance.getClass().getName()));
  	})
  	.map(field -> {
  	try {
  	field.setAccessible(true);
  	return (ResourceBundle) field.get(instance);
  	} catch (IllegalAccessException e) {
  	throw new RuntimeException(error(2005).formatted(field.getName(), instance.getClass().getName()), e);
  	}
  	})
  	.filter(Objects::nonNull)
  	.findFirst()
  	.orElse(defaultResourceBundle);

  Please simplify.
• This stream would be more readable as a simple forEach lambda that does not require Pairs.

  fulibFx/framework/src/main/java/org/fulib/fx/controller/ControllerManager.java

  Lines 314 to 328 in 4264510

  	Reflection.getFieldsOfType(instance.getClass(), Subscriber.class) // Get all Subscriber fields
  	.map(field -> {
  	try {
  	field.setAccessible(true);
  	return new Pair<>(field, (Subscriber) field.get(instance)); // Get the Subscriber instance, if it exists
  	} catch (IllegalAccessException e) {
  	return null;
  	}
  	})
  	.filter(Objects::nonNull)
  	.filter(pair -> pair.getKey() != null)
  	.filter(pair -> !pair.getValue().isDisposed()) // Filter out disposed subscribers
  	.forEach(pair ->
  	FulibFxApp.LOGGER.warning("Found undestroyed subscriber '%s' in class '%s'.".formatted(pair.getKey().getName(), instance.getClass().getName()))
  	);

• This supposed utility method has side effects in the filter lambda:

  fulibFx/framework/src/main/java/org/fulib/fx/controller/ControllerManager.java

  Lines 442 to 450 in 4264510

  	return Reflection.getAllFieldsWithAnnotation(instance.getClass(), SubComponent.class)
  	.filter(field -> {
  	if (ControllerUtil.isComponent(field.getType())) return true;
  	if (!ControllerUtil.canProvideSubComponent(field)) {
  	FulibFxApp.LOGGER.warning(error(6005).formatted(field.getName(), instance.getClass().getName()));
  	}
  	return false;
  	}).toList();

  Please put the warning into a more appropriate place where it is not printed every time the method is called.