Union broken in SQLite

[rmhsilva]

The union family of commands generate parentheses, which are invalid in SQLite.

e.g. from README

(union-queries
 (select (:name :birthday) (from :fulltime))
 (select (:name :birthday) (from :parttime)))
;=> #<SXQL-OP: (SELECT name, birthday FROM fulltime) UNION (SELECT name, birthday FROM parttime)>

For SQLite, this should generate:

SELECT name, birthday FROM fulltime UNION SELECT name, birthday FROM parttime

Without the brackets around the SELECT statements.

[jackcarrozzo]

You can fix this by removing the parens on line 208 of src/operator.lisp:

;; original format string is ~~{(~~A)~~^ ~a ~~}
(append (list (format nil ,(format nil "~~{~~A~~^ ~a ~~}" keyword)

And lo,

SXQL> (yield (union-queries
                              (select (:name :birthday) (from :fulltime))
                              (select (:name :birthday) (from :parttime))))
"SELECT name, birthday FROM fulltime UNION SELECT name, birthday FROM parttime"
NIL
SXQL> 

[jackcarrozzo]

FWIW- I checked that the new syntax (lacking parens) is compatible with mysql and postgres too - it is. I'm happy to submit a PR but someone is going to have to show me how to run the tests, cuz I've only figured out how to test one file at a time.

[rmhsilva]

Ahaa, nice. I had a quick look through the code to try and figure out where they parens were coming from, but gave up pretty quickly because I don't actually need Unions right now!