Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supprot React 17 in peer dependency declaration #182

Closed
tomdracz opened this issue Apr 12, 2022 · 8 comments
Closed

Supprot React 17 in peer dependency declaration #182

tomdracz opened this issue Apr 12, 2022 · 8 comments

Comments

@tomdracz
Copy link

With the support added for React 18, we've ended up with the following peer dependency declarations:

https://github.com/fullcalendar/fullcalendar-react/blob/master/package.json#L47-L48

  "peerDependencies": {
    "react": "^16.7.0 || ^18",
    "react-dom": "^16.7.0 || ^18"
  },

This will trigger incorrect peer dependency warning for React 17, even though I don't think it should. Do we need ^17 be included as the version also?

@IsaacTrevino
Copy link

I'm getting the same issue, even when I downgrade to 5.10.1. Why remove support for React 17?

@acerix acerix changed the title Peer dependency declaration Supprot React 17 in peer dependency declaration Apr 14, 2022
@Jule-
Copy link

Jule- commented Apr 19, 2022

This is breaking change.

  1. Is there any reason to drop support of react@^17?
  2. If you want to drop support for react@^17, please bump major version.
  3. If you don't want to, just add support to react@^18 ("react": "^16.7.0 || ^17 || ^18")

Thanks for cleaning this up! 🙂

@tomdracz
Copy link
Author

For what it's worth, that looks like dependency setting mistake rather than actual support being dropped for React 17. Why the hell would React 16.7 be supported!

I'm running the latest version against React 17 without any problems FYI.

Either way, we need a new version out to sort this out.

@Jule-
Copy link

Jule- commented Apr 20, 2022

Ping @arshaw 😉

@arshaw
Copy link
Member

arshaw commented Apr 21, 2022

This is a mistake. I will fix this ASAP.

@arshaw
Copy link
Member

arshaw commented Apr 21, 2022

I released the fix in v5.11.1. Can someone please confirm?

@tomdracz
Copy link
Author

Can confirm 5.11.1 fixes this. Thanks @arshaw !

@Jule-
Copy link

Jule- commented Apr 21, 2022

Thanks @arshaw ! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants