-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supprot React 17 in peer dependency declaration #182
Comments
I'm getting the same issue, even when I downgrade to |
This is breaking change.
Thanks for cleaning this up! 🙂 |
For what it's worth, that looks like dependency setting mistake rather than actual support being dropped for React 17. Why the hell would React 16.7 be supported! I'm running the latest version against React 17 without any problems FYI. Either way, we need a new version out to sort this out. |
Ping @arshaw 😉 |
This is a mistake. I will fix this ASAP. |
I released the fix in v5.11.1. Can someone please confirm? |
Can confirm 5.11.1 fixes this. Thanks @arshaw ! |
Thanks @arshaw ! 🙂 |
With the support added for React 18, we've ended up with the following peer dependency declarations:
https://github.com/fullcalendar/fullcalendar-react/blob/master/package.json#L47-L48
This will trigger incorrect peer dependency warning for React 17, even though I don't think it should. Do we need
^17
be included as the version also?The text was updated successfully, but these errors were encountered: