Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong export in types for DateTimeFormat #28

Closed
Ayc0 opened this issue Feb 19, 2024 · 2 comments
Closed

Wrong export in types for DateTimeFormat #28

Ayc0 opened this issue Feb 19, 2024 · 2 comments

Comments

@Ayc0
Copy link

Ayc0 commented Feb 19, 2024

In impl.esm.js, we export DateTimeFormat, Temporal, and toTemporalInstant:

image

But in index.d.ts, we re-export from temporal-spec
image

which exports Temporal, Intl, and toTemporalInstant

image

So according to the types, we should be using Intl.DateTimeFormat and not DateTimeFormat which is not accurate

@arshaw
Copy link
Member

arshaw commented Feb 20, 2024

You are very right. I'll fix this for the next release.

@arshaw
Copy link
Member

arshaw commented Feb 21, 2024

This has been fixed and released in v0.2.2. Thank you for the report.

@arshaw arshaw closed this as completed Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants