Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade http-kit for JDK 9 #4

Open
tirkarthi opened this issue Apr 13, 2018 · 1 comment
Open

Upgrade http-kit for JDK 9 #4

tirkarthi opened this issue Apr 13, 2018 · 1 comment

Comments

@tirkarthi
Copy link

It seems that the project uses a version of http-kit that is incompatible with JDK 9 and above. It is fixed upstream and upgrading it will help in JDK 9 compatibility.

Relevant http-kit upstream issue : http-kit/http-kit#356
Relevant release : https://github.com/http-kit/http-kit/releases/tag/2.3.0-beta2
Latest RC release : https://github.com/http-kit/http-kit/releases/tag/v2.3.0-RC1

This was reported using Clojars metadata and GitHub search. Feel free to close this if it's irrelevant.

➜  foo lein repl
nREPL server started on port 33226 on host 127.0.0.1 - nrepl://127.0.0.1:33226
REPL-y 0.3.7, nREPL 0.2.12
Clojure 1.9.0
Java HotSpot(TM) 64-Bit Server VM 9.0.4+11
    Docs: (doc function-name-here)
          (find-doc "part-of-name-here")
  Source: (source function-name-here)
 Javadoc: (javadoc java-object-or-class-here)
    Exit: Control+D or (exit) or (quit)
 Results: Stored in vars *1, *2, *3, an exception in *e

user=> (require '[full.http.client :as c])
WARNING: boolean? already refers to: #'clojure.core/boolean? in namespace: clojure.tools.analyzer.utils, being replaced by: #'clojure.tools.analyzer.utils/boolean?
WARNING: boolean? already refers to: #'clojure.core/boolean? in namespace: clojure.tools.analyzer, being replaced by: #'clojure.tools.analyzer.utils/boolean?
WARNING: bounded-count already refers to: #'clojure.core/bounded-count in namespace: clojure.core.async, being replaced by: #'clojure.core.async/bounded-count

ClassNotFoundException javax.xml.bind.DatatypeConverter  jdk.internal.loader.BuiltinClassLoader.loadClass (BuiltinClassLoader.java:582)

project.clj

(defproject foo "0.1.0-SNAPSHOT"
  :description "FIXME: write description"
  :url "http://example.com/FIXME"
  :license {:name "Eclipse Public License"
            :url "http://www.eclipse.org/legal/epl-v10.html"}
  :dependencies [[org.clojure/clojure "1.9.0"]
                 [fullcontact/full.http "1.0.1"]])
@tirkarthi
Copy link
Author

I could see fullcontact/http-kit a fork of http-kit being used a dependency. I don't know if it's intentional and the fix would be to apply the patch at http-kit/http-kit#356 to the fork.

Feel free to close this if it's intentional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant