Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced conversion precision prevents model fitting #225

Open
jhug12 opened this issue Jun 7, 2024 · 0 comments · May be fixed by #226
Open

Reduced conversion precision prevents model fitting #225

jhug12 opened this issue Jun 7, 2024 · 0 comments · May be fixed by #226
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jhug12
Copy link

jhug12 commented Jun 7, 2024

Describe the bug
The use of float32 precision in the X_to_numpy and y_to_numpy functions leads to numerical problems when fitting the elastic_net_cv forecaster. This reduced precision causes a ValueError in the sklearn api when computing the gram matrix

To Reproduce
Tried unsuccessfully to reproduce it using random data.

**Desktop **

  • OS: Windows 10
  • Python: 3.10.0
  • functime: 0.9.5

Additional context
This issue seems related to the general precision problem discussed in scikit-learn#21997. A potential enhancement could be to allow configuration of precision level through an API option, improving the flexibility and applicability of the model in diverse scenarios.

@jhug12 jhug12 linked a pull request Jun 7, 2024 that will close this issue
@baggiponte baggiponte added the bug Something isn't working label Jun 9, 2024
@baggiponte baggiponte added this to the 0.9.X milestone Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants