Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

longest_streak_above/below_mean uses deprecated struct fields #255

Open
david-waterworth opened this issue Oct 2, 2024 · 0 comments · May be fixed by #256
Open

longest_streak_above/below_mean uses deprecated struct fields #255

david-waterworth opened this issue Oct 2, 2024 · 0 comments · May be fixed by #256

Comments

@david-waterworth
Copy link

david-waterworth commented Oct 2, 2024

longest_streak_above_mean and longest_streak_below_mean use the polars rle function that returns

Expression of data type Struct with fields `len` of data type UInt32 and `value` of the original data type

functime expects length rather than len and value rather than values so fails on latest polars release

result = y.filter(y.struct.field("values")).struct.field("lengths").max()

result = y.filter(y.struct.field("values")).struct.field("lengths").max()

I'm happy to create a pull request once #245 gets merged

@david-waterworth david-waterworth changed the title longest_streak_above/below_mean uses deprecated struct field longest_streak_above/below_mean uses deprecated struct fields Oct 2, 2024
@tjader tjader linked a pull request Nov 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant