-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question about the Sign of SIMSE Loss #9
Comments
Hi, do you have the code of the original paper? It seems that the github link in the paper cannot be entered |
The official implementation of the DSN model is in the archive brach, the link is as follows:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, I was reading the DSN paper and saw you codes here. Nice codes!
But here I was wondering whether the loss codes in
train.py
's line 189 & 245 should beloss -= source_simse
andloss -= target_simse
. To confirm this, I read the originalscale-invariant mean squared error
paper, especially the eqn. 4 and made this conclusion.I thought if so, the acc can be higher, and get close to DSN's result~
The text was updated successfully, but these errors were encountered: