Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the Sign of SIMSE Loss #9

Open
MaxLiu245 opened this issue Sep 19, 2020 · 3 comments
Open

Question about the Sign of SIMSE Loss #9

MaxLiu245 opened this issue Sep 19, 2020 · 3 comments

Comments

@MaxLiu245
Copy link

Hi, I was reading the DSN paper and saw you codes here. Nice codes!

But here I was wondering whether the loss codes in train.py's line 189 & 245 should be loss -= source_simse and loss -= target_simse. To confirm this, I read the original scale-invariant mean squared error paper, especially the eqn. 4 and made this conclusion.

I thought if so, the acc can be higher, and get close to DSN's result~

@BX-xb
Copy link

BX-xb commented Nov 13, 2020

Hi, do you have the code of the original paper? It seems that the github link in the paper cannot be entered

@codenie
Copy link

codenie commented Nov 16, 2020

The official implementation of the DSN model is in the archive brach, the link is as follows:
https://github.com/tensorflow/models/tree/archive/research/domain_adaptation

Hi, do you have the code of the original paper? It seems that the github link in the paper cannot be entered

@codenie
Copy link

codenie commented Mar 9, 2021

In addition to the sign, the log should also be used, according to the equation of SIMSE:
image
where image
Is this right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants