New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take the localStorage out as parameter? #56

Open

dmitriz opened this issue May 29, 2017 · 0 comments

Contributor

dmitriz commented May 29, 2017 •

edited

Loading

Just an idea,
motivated by the discussion in https://github.com/uzujs/uzu/issues/6#issuecomment-304519136,
maybe taking out the local Storage here as external parameter would make the data flow more explicit:
https://github.com/funkia/turbine/blob/master/examples/todo/src/TodoApp.ts#L69

Somehow I feel it does not really belong to the main app but comes from outside.

It might be interesting to compare with the implementation here:
https://github.com/briancavalier/most-todomvc/blob/master/src/index.js#L75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment