Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protection isn't kicking in #95

Closed
nevir opened this issue Aug 27, 2017 · 4 comments
Closed

Protection isn't kicking in #95

nevir opened this issue Aug 27, 2017 · 4 comments
Assignees

Comments

@nevir
Copy link

nevir commented Aug 27, 2017

Tab Modifier version

Browser: Chrome (62.0.3192.0)

Extension version: 0.20.0

Expected behavior

Pressing cmd-w (or file -> close tab) on a protected tab should warn about it

Actual behavior

When pressing cmd-w to close the current tab, tab protection doesn't kick in (the tab closes immediately without a prompt)

@sylouuu
Copy link
Collaborator

sylouuu commented Aug 28, 2017

Hey @nevir,

Thanks for your feedback. I've done some researches about this. Since Chrome 60, the event beforeunload that triggers the protected action has been reworked. Check out the official Google article and this SO answer. In my opinion, this is a good decision made by Chrome for end users.

That means, the protected action on a TM rule may or may not works depending on your interaction with the page.

I'll add a short note to the README to reference this issue.

Best

@nevir
Copy link
Author

nevir commented Aug 28, 2017

Ah! Thanks for the details

@sylouuu sylouuu closed this as completed Aug 28, 2017
@pflegende
Copy link

it is yet also (opera Version:66.0.3515.115)
(especialy with the close-icon on every tab)

workaround:
immediately after open the tab:
on the right klick -> "close ..." then apears the message, - nice! -
and in follow up the close-icon also seems sensitiv ...

@ask-compu
Copy link

why is this issue closed if this problem still happens?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants