Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not calling AnsiConsole.systemInstall() makes a difference under Windows CMD.exe console #281

Open
ceki opened this issue Jan 23, 2024 · 0 comments

Comments

@ceki
Copy link

ceki commented Jan 23, 2024

The logback project got a puzzling report recently which might be of interest here.

The wrapWithJansi method in ConsoleAppender supports both Jansi 1.x and 2.x.

However, it does so without calling AnsiConsole.systemInstall().

Windows CMD terminal and Jansi 1.18, calling AnsiConsole.wrapSystemOut(...) seems to suffice even if AnsiConsole.systemInstall() is not called.

Windows CMD terminal and Jansi 2.4, calling AnsiConsole.out() seems to be insufficient (with a missing AnsiConsole.systemInstall() invocation).

My question is whether calling AnsiConsole.systemInstall() is mandatory in Jansi 2.x ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant