Skip to content

Project abandonned -> Fork! #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hoijui opened this issue Nov 3, 2023 · 4 comments
Closed

Project abandonned -> Fork! #22

hoijui opened this issue Nov 3, 2023 · 4 comments

Comments

@hoijui
Copy link

hoijui commented Nov 3, 2023

Hey everyone interested.
It seems obvious that this repo is not maintained anymore (last activity was in December 2021) , thus I suggest to fork it, maybe rename it in the fork, and adding a few of the people that made PRs here maintainers on the new repo, so we will not end up with a headless repo again so easily.
Then we should of course also release that new version; probably under a new name.

Looking shortly at the forks with changes here:
https://github.com/fusion-engineering/rust-git-version/network
I would have chosen @darthdeus fork as the new base,
but maybe the current version from this repo would be more democratic and save.

I am happy with anyone doing this. I would also do the basic part of it myself, if no-one else steps up.

@baxterjo
Copy link
Contributor

baxterjo commented Nov 5, 2023

I would prefer a new fork. I understand why @darthdeus made the fork they did. But I want to keep args.

Edit: Also, has anyone tried reaching out to the owners of the repo directly?

@de-vri-es
Copy link
Collaborator

de-vri-es commented Nov 15, 2023

Hello! I understand the sentiment. But honestly, for the API, I think very little additions or changes are needed. This is basically just a simple wrapper around git describe and it is not intended to be more.

The upgrade to syn v2 was nice and is now released.

Something to make it work when run outside of git also makes sense, so a PR that creates a static Result or Option would be something I would certainly appreciate too. This is already possible with the cargo_prefix/suffix arguments and the fallback argument.

@de-vri-es
Copy link
Collaborator

Anyway, thanks for the reminder that this crate needs some maintenance. Closing this issue since I'm looking at the repository now :)

@hoijui
Copy link
Author

hoijui commented Nov 17, 2023

Thank you @de-vri-es for the care that day! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants