Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] modify event data fields to make it easier for developing marketplace #436

Open
leo-plugdefi opened this issue Jan 31, 2023 · 0 comments
Open

[Feature Request] modify event data fields to make it easier for developing marketplace #436

leo-plugdefi opened this issue Jan 31, 2023 · 0 comments
Labels
pallet:nft

Comments

@leo-plugdefi
Copy link
Collaborator

observation:

  1. the FixedPriceSaleList event doesn't contain duration of this listing, to get this field in current implementation it will require another storage read call and calculate using listing close field and the block number.
  2. the Offer event doesn't contain token_id, the indexer has to get this info from extrinsic parameters

proposal:
add those data to the events mentioned above
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pallet:nft
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leo-plugdefi