Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid reverts in puzzle 10 #4

Open
charles-cooper opened this issue Mar 6, 2022 · 1 comment
Open

invalid reverts in puzzle 10 #4

charles-cooper opened this issue Mar 6, 2022 · 1 comment

Comments

@charles-cooper
Copy link

In

"code": "38349011600857FD5B3661000390061534600A0157FDFDFDFD5B00",
, there are several REVERT instructions, but since there aren't enough items on the stack, they don't actually revert, I think they trigger an exceptional halting state (same as 0xFE INVALID). For clarity, maybe these instructions should be changed to 0xFE - or start the code with MSIZE MSIZE so that the REVERT opcodes will have enough stack items to consume!

@fvictorio
Copy link
Owner

Oops, you're right, I should've used 0xFE. I'll change that, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants