Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support require() imports #1086

Open
fwouts opened this issue Oct 11, 2022 · 3 comments
Open

Support require() imports #1086

fwouts opened this issue Oct 11, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@fwouts
Copy link
Owner

fwouts commented Oct 11, 2022

Preview.js currently crashes if you use require() for imports because Vite doesn't support them.

This might be fixable with a Vite plugin, see vitejs/vite#3409 for further reference.
@fwouts fwouts added the enhancement New feature or request label Oct 11, 2022
@dohooo
Copy link
Contributor

dohooo commented Dec 1, 2022 •
edited
Loading

I'll try it.

@fwouts
Copy link
Owner Author

fwouts commented Dec 11, 2022

@dohooo any luck so far with this?

@dohooo
Copy link
Contributor

dohooo commented Dec 11, 2022

@dohooo any luck so far with this?

Sorry, Currently I don't have any time to do this. I was suddenly assigned some new work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Preview.js
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fwouts @dohooo