Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThinkPad P1 Gen 5 -- cannot install System Firmware 1.23 and Embedded Controller 0.1.12 #453

Open
franck-iaropoli-arm opened this issue Jun 27, 2024 · 4 comments

Comments

@franck-iaropoli-arm
Copy link

Hi everyone,
I am not able to install on a ThinkPad P1 Gen 5 System Firmware 1.23 and Embedded Controller 0.1.12
Is there any additional logs I can share to help ?

$ sudo fwupdmgr get-history                                                                                        
21DDS6SP00                                                                                                                                                  
│                                                                                                                                    
├─Embedded Controller:                                            
│ │   Device ID:          97b6fe9b220c7b9e1a3a1d9f404c00d4fe77ae7e                                                                                          
│ │   Previous version:   0.1.11                                                                                                                            
│ │   Update State:       Failed                                              
│ │   Update Error:       failed to run update on reboot                                                                                                                                   
│ │   Last modified:      2024-06-27 14:11                                                                                                                                                 
│ │   GUID:               f8963b51-51b6-4059-87c4-722967c16745                                                       
│ │   Device Flags:       • Internal device                                                                                          
│ │                       • Updatable                                         
│ │                       • System requires external power source                                                                    
│ │                       • Supported on remote server                        
│ │                       • Needs a reboot after installation                                                                                                                              
│ │                       • Device is usable for the duration of the update                                                                                 
│ │                                                                                                                                                                                                                                       
│ └─ThinkPad P1 Gen 5/X1 Extreme Gen 5:                                                                                                                                                                                                   
│       New version:      0.1.12                                                                                                     
│       Remote ID:        lvfs                                                                                       
│       Release ID:       93501
│       Summary:          Lenovo ThinkPad P1 Gen 5/X1 Extreme Gen 5 System Firmware                                                                         
│       License:          Proprietary                                                                                                                        
│       Size:             1.1 MB                                              
│       Created:          2024-05-14                                          
│       Urgency:          High                                                
│       Vendor:           Lenovo                                              
│       Release Flags:    • Is upgrade                                        
│       Description:                                                          
│       Changes in this releae version 1.12                                   
│                                                                             
│       Important updates - Nothing                                           
│                                                                             
│       New functions or enhancements - Updated PDFW                          
│                                                                             
│       Problem fixes - Nothing                                               
│                                                                             
└─System Firmware:                                                            
  │   Device ID:          5bfc5b91c18ef8b751d3d052af77b69ebf738038                                                                                          
  │   Previous version:   0.1.22                                                                                                                             
  │   Update State:       Failed                                              
  │   Update Error:       failed to run update on reboot                      
  │   Last modified:      2024-06-27 14:11                                    
  │   GUID:               3a6cdf97-cfb9-479d-9c4c-135e0d4505c9                
  │   Device Flags:       • Internal device                                   
  │                       • Updatable                                         
  │                       • System requires external power source             
  │                       • Supported on remote server                        
  │                       • Needs a reboot after installation                 
  │                       • Cryptographic hash verification is available                                                                                    
  │                       • Device is usable for the duration of the update                                                                                  
  │                                                                                                                                                          
  └─ThinkPad P1 Gen 5/X1 Extreme Gen 5:                                       
        New version:      0.1.23                                              
        Remote ID:        lvfs                                                
        Release ID:       93500                                               
        Summary:          Lenovo ThinkPad P1 Gen 5/X1 Extreme Gen 5 System Firmware                                                                         
        License:          Proprietary                                                                                                                        
        Size:             22.2 MB                                             
        Created:          2024-05-14                                          
        Urgency:          High                                                
        Vendor:           Lenovo                                              
        Release Flags:    • Is upgrade                                        
        Description:                                                          
        Changes in this release - version 1.23                                
                                                                              
        New functions or enhancements - Updated the Diagnostics module to version 04.34.001.
@mrhpearson
Copy link
Collaborator

Is there anything displayed (even briefly) on screen during the reboot?
Can you confirm which distro you have installed and which version of fwupdmgr you are running please?

@franck-iaropoli-arm
Copy link
Author

Hi @mrhpearson,
Yes something like "BIOS self-healed from previous BIOS version"
The machine is running Ubuntu 22.04 with fwupd 1.7.9-1~22.04.3

@mrhpearson
Copy link
Collaborator

Sorry for the slow reply - holiday in Canada on Monday.

Couple of suggestions before I raise this to the FW team:

Looking at the logs on LVFS - there are some failure logs but they are all with fwupd 1.7.9. Can you try with a newer version please? The FW team tested with 1.7.15.
You can do this either by using the snap, or boot a Fedora live USB session and try from there.

If that doesn't work can you also try doing just one update (the BIOS) instead of both BIOS and EC together to see if that works - it's been a long time since we've had that kind of problem but just to rule it out.

There is also version 1.23 on LVFS now - but there were 10k+ updates of 1.22 so I'm hesitant to blame the FW update itself.

Thanks!
Mark

@franck-iaropoli-arm
Copy link
Author

No problem @mrhpearson
I have tried with fwupd snap and 1.23 firmware same results.
We have raised a ticket with Lenovo support as we may have an hardware issue with this machine.
I will keep you posted :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants