Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize "Copy this in your ~/.kube/config file" page #6

Closed
emptywee opened this issue Oct 22, 2018 · 4 comments
Closed

Customize "Copy this in your ~/.kube/config file" page #6

emptywee opened this issue Oct 22, 2018 · 4 comments

Comments

@emptywee
Copy link

Hi and thanks for the great login app.

Is there any plans to allow customization of the "Copy this in your ~/.kube/config file" page? I'd like to make it a bit more clear where to place it exactly. And maybe provide per-cluster instructions.

Just curious at this time.

@fydrah
Copy link
Owner

fydrah commented Oct 23, 2018

Hi @emptywee ,

This was not planed, but it is a good idea.

I could extract the HTML templates from the code, then you will be able to configure whatever you want in the template (no need to re-create the image, you could use a configmap to override the HTML template you want).

Could this suit to your needs ?

@emptywee
Copy link
Author

Absolutely. Would be a good start! 👍

@fydrah
Copy link
Owner

fydrah commented Oct 29, 2018

Hi @emptywee,
The feature has been merged on 2.4.0

@fydrah
Copy link
Owner

fydrah commented Oct 30, 2018

I'm closing this issue since the feature has been merged.

Do not hesitate to open a new one if you have other feature request/issues.

@fydrah fydrah closed this as completed Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants