-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
formDialog doesn't have item hints and thus misses validation error messages #2781
Labels
bug
Something isn't working
Milestone
Comments
I'm not sure this is quite accurate. The output for validation should be present if there is |
Yeah, it looks like the Form dialog isn't re-using the Form widget code like it should and/or replicate the space reserved for validation errors. |
andydotxyz
added
bug
Something isn't working
and removed
unverified
A bug that has been reported but not verified
labels
Feb 15, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug:
dialog.formDialog
looks very similar towidget.Form
but, as the code is different, there's a difference:widget.Form
considersFormItem.HintText
and createshelperOutput
text widgets for items, and then it uses thehelperOutput
s to show validation errors if they occur.dialog.NewForm
uses its own code and thus it missesHintText
andhelperOutput
, and thus validation error messages are missed.To Reproduce:
Steps to reproduce the behaviour:
fyne_demo
.Widgets/Form
tab.aaaa
to the Email field and click to another field.Your full name
will be replaced withnot a valid email
.Dialogs
tab and click theForm Dialog
button.Device (please complete the following information):
The text was updated successfully, but these errors were encountered: