Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove observer toggles #22

Open
manishmeganathan opened this issue May 28, 2021 · 0 comments
Open

Remove observer toggles #22

manishmeganathan opened this issue May 28, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request log observation Issues that deal with the log handling between services orchestrator Issues that deal with orchestrator functionality

Comments

@manishmeganathan
Copy link
Member

  • Reimplement the concept of observer toggles. Use a pointer to a field in the MeshOrchestrator struct instead of a variable inside the runtime, similar toSimulatorOn. Let's call it ObserverationOn.
  • Use the same new field to also lock the Observation method of the server, such that only one mesh observer can connect to the mesh log stream at any given point in time. Treat it essentially as a synchronisation lock for the observation log stream.
@manishmeganathan manishmeganathan added enhancement New feature or request log observation Issues that deal with the log handling between services orchestrator Issues that deal with orchestrator functionality labels May 28, 2021
@manishmeganathan manishmeganathan self-assigned this May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request log observation Issues that deal with the log handling between services orchestrator Issues that deal with orchestrator functionality
Projects
None yet
Development

No branches or pull requests

1 participant