-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt init to work with v6 of timbre for #67 #68
base: master
Are you sure you want to change the base?
Conversation
Thanks for your work on this @vincentjames501!
It was never a great solution to compare IIRC, the reason I used Re. |
@rufoa , feel free to modify this MR as you see fit. This does fix it for us locally while still allowing changes at runtime. It may make sense to just bump the major version of this package and just say this is only usable for v6 of timbre? |
@rufoa , can we collab a bit more on getting this one in? Would bumping the major version of this project help here while saying it's only compatible with v6 of timbre? |
Sorry, things have been very hectic lately. I'll sort it out this weekend. I agree that we can ditch support for timbre 5 and bump our version correspondingly |
I COMPLETELY understand and thank you for your work on this! |
Hi @vincentjames501, I've just pushed version I'll look into the LOG_LEVEL and compile-time elision stuff separately, because I'm not convinced that's ever actually worked properly, and will have to familiarise myself with the code again. Thanks again for your patience and understanding while I got round to working on this! |
@rufoa , thanks! So far it's looking good. |
Thanks for the good work @vincentjames501 and @rufoa Using |
And cc @vemv who opened the original issue back in 2018. (We just updated timbre and got this bug.) |
I believe this fixes #67 but I admit I'm not positive on the original intent here using the elision env var TIMBRE_LEVEL? It looks like
timbre/compile-time-min-level
will resolve each of the vars though: