VAT formatter does not work in fr_FR namespace

[thomasgataly]

Hello,
The error occurs when I try to use the vat formatter. This formatter use the siren method which does not exists in the class and its parent. This method seems to be defined in the Faker\Provider\fr_FR\Company class.

[raphaeldealmeida]

Hi @thomasngataly

I think VAT is Payment Provider
Give me a code example please

[thomasgataly]

Hi @raphaeldealmeida

The code inside the VAT method calls an undefined siren method. See the code below

Faker/src/Faker/Provider/fr_FR/Payment.php

Line 24 in 910a79d

return sprintf("%s%s%s%s", $prefix, self::randomNumber(2, true), $this->siren($spacedNationalPrefix));

[irozgar]

Hi

I also have this issue. I've seen that this commit is the one that introduced the change that broke this, because the method siren does not exist in the class Payment for fr_FR locale or in its parent class.

[jocel1]

Hi @raphaeldealmeida ,

Same issue for me, code example to reproduce the issue is simple:

$faker = Factory::create('fr_FR');
echo $faker->vat();

[ppelgrims]

What do you think about making the method static?

    public function vat($spacedNationalPrefix = true)
    {
        $prefix = ($spacedNationalPrefix) ? "FR " : "FR";

-       return sprintf("%s%s%s%s", $prefix, self::randomNumber(2, true), $this->siren($spacedNationalPrefix));
+       return sprintf("%s%s%s%s", $prefix, self::randomNumber(2, true), Company::siren($spacedNationalPrefix));

    }

[fzaninotto]

Fixed by #1381

[jdecool]

Does this fix will be released soon ?

[ppelgrims]

@jdecool see #1391

[jdecool]

Thanks @ppelgrims.

I saw it, but I can't set a dependency point to the master branch, even if it's only required for development.

This issue was fixed nearly 3 months ago...

[ppelgrims]

I don't know what the policy or planning is for releases but I thought that could help you out in the mean time. Can't be of any more help I'm afraid.

[jdecool]

No problem @ppelgrims, thanks for the suggestion :)