Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ui_state attribute to be used with arbitrary associated struct name #2337

Closed
Vollbrecht opened this issue Oct 2, 2024 · 2 comments · Fixed by #2393
Closed

Allow ui_state attribute to be used with arbitrary associated struct name #2337

Vollbrecht opened this issue Oct 2, 2024 · 2 comments · Fixed by #2393
Labels
enhancement New feature or request

Comments

@Vollbrecht
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Its not documented and non intuitive that the ui_state attribute can only be used with something that is exactly called RustState

Describe the solution you'd like
Allow for arbitrary struct naming of a struct annotated with ui_state

Describe alternatives you've considered
Warn the user if he uses the ui_state attribute on a struct that is not exactly RustState and document this implicit behavior.

@Vollbrecht Vollbrecht added the enhancement New feature or request label Oct 2, 2024
@fzyzcjy
Copy link
Owner

fzyzcjy commented Oct 3, 2024

Totally agree, we should support that! (Originally it was more like a quick demo so was quite minimal) Feel free to PR, alternatively I will work on it later (may not guarantee to be within days since this is related to experimental feature).

Btw possibly related: #2307

Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
2 participants