-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code cleanup: dart/ty.rs is accidentically modified #590
Comments
I'll take a better look on this once I finish the exceptions PR, cause I'm really bad at multitasking. Is it ok? |
Sure, take your time! |
I can come up with a PR if you want guys. should None be preserved ?either: fn structs(&self) -> String {
if let IrTypeDelegate::PrimitiveEnum { ir, .. } = &self.ir {
super::TypeEnumRefGenerator {
ir: ir.clone(),
context: self.context.clone(),
}
.structs()
} else {
"".into()
}
} or: fn structs(&self) -> String {
if let IrTypeDelegate::PrimitiveEnum { ir, .. } = &self.ir {
let mut context = self.context.clone();
context.dart_api_class_name = None;
super::TypeEnumRefGenerator {
ir: ir.clone(),
context,
}
.structs()
} else {
"".into()
}
} |
@Roms1383 That would be great :) The immutable approach looks better IMHO |
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new issue. |
See #543 (comment) for details
/cc @lattice0 Maybe we can simply PR and revert this?
/cc @Desdaemon I also find this snippet in #589...
The text was updated successfully, but these errors were encountered: